Uploaded image for project: 'XNAT'
  1. XNAT
  2. XNAT-5971

Correct access.log order standardization

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.7.6
    • Fix Version/s: 1.7.6
    • Component/s: None
    • Labels:
      None
    • Environment:

      Branches of xnat-web and xdat: fixes/1.7.6-rherrick

    • Rank:
      0|ii1o3b:

      Description

      It's important to standardize as much as possible in access.log, so that they admin reading it can synthesize information as quickly and painlessly as possible. Here's a sample excerpt from access.log on a war running the branches specified in the environment:

      2019-03-01 19:41:44,498 - admin 10.1.100.1  http://10.1.100.17/xapi/spawner/namespaces "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/72.0.3626.109 Safari/537.36" GET
      2019-03-01 19:41:44,521 - admin 10.1.100.1  http://10.1.100.17/xapi/siteConfig/buildInfo "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/72.0.3626.109 Safari/537.36" GET
      2019-03-01 19:41:44,578 - admin 10.1.100.1  GET http://10.1.100.17/REST/projects/MultiProcArc/groups?format=json "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/72.0.3626.109 Safari/537.36"
      2019-03-01 19:41:44,589 - admin 10.1.100.1  GET http://10.1.100.17/data/config/edit/projects/MultiProcArc/image/dicom/script?format=json&rnd=1551469304580 "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/72.0.3626.109 Safari/537.36"
      

      Here's a snippet from a few days ago running a war without these changes:

      2019-02-27 15:38:32,842 - admin 0:0:0:0:0:0:0:1 GET http://10.1.100.17/data/projects?format=json&favorite=true&XNAT_XHR=x0azk6v4z-1551282206432
      2019-02-27 15:38:32,854 - admin 10.1.100.1 GET http://10.1.100.17/xapi/access/displays/browseableCreateable
      2019-02-27 15:38:32,857 - admin 127.0.0.1 GET http://10.1.100.17/data/search/saved?format=json&XNAT_XHR=xcfmpawtz-1551282206440
      2019-02-27 15:38:32,868 - admin 10.1.100.1 GET http://10.1.100.17/xapi/siteConfig/buildInfo
      

      The issue is the order of the components. Previously, it was always:

      1. Timestamp
      2. User
      3. IP
      4. HTTP method (or SCREEN)
      5. URL

      However, since the change, note that the HTTP method and URL are interchanged depending on whether the URL is an XAPI endpoint or not. It's probably best for the method to come first (since it's much shorter than the URL), but it definitely needs to be consistent.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              moore.c@wustl.edu Charlie Moore
              Reporter:
              moore.c@wustl.edu Charlie Moore
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 hour
                  1h