Uploaded image for project: 'XNAT'
  1. XNAT
  2. XNAT-4242

Admin UI/Spawner should support validation

    Details

    • Sprint:
      1.7 Sprint 7, 1.7 Release Sprint, 1.7.1 Release Sprint 1
    • Rank:
      0|0hzzhm:7
    • Sprint:
      1.7 Sprint 7, 1.7 Release Sprint, 1.7.1 Release Sprint 1

      Description

      For example, for Session Timeout, I would expect the field to only want integers greater than 1 (0 and 1 do not work very well) and Maximum Concurrent Sessions to be restricted to positive integers. Currently, it seems like you can throw more or less whatever you want in here (salsa minutes until logout) and save.

        Issue Links

          Activity

          Hide
          moore.c@wustl.edu Charlie Moore added a comment -

          Some backend validation would be nice too to prevent SQL injection, etc.

          Show
          moore.c@wustl.edu Charlie Moore added a comment - Some backend validation would be nice too to prevent SQL injection, etc.
          Hide
          markflorida@wustl.edu Mark Florida added a comment -

          Front-end validation will now stop form submission if there are errors. As long as the validation methods work as they should, we're good - the validation methods can be augmented as needed.

          Show
          markflorida@wustl.edu Mark Florida added a comment - Front-end validation will now stop form submission if there are errors. As long as the validation methods work as they should, we're good - the validation methods can be augmented as needed.
          Hide
          moore.c@wustl.edu Charlie Moore added a comment -

          I tried this on the PostgreSQL interval fields and it never stopped submission, even with choices like "47 ravioli" (side note: do NOT set your session timeout to "47 ravioli").

          Show
          moore.c@wustl.edu Charlie Moore added a comment - I tried this on the PostgreSQL interval fields and it never stopped submission, even with choices like "47 ravioli" (side note: do NOT set your session timeout to "47 ravioli").
          Hide
          markflorida@wustl.edu Mark Florida added a comment -

          This is the kind of thing that could use JS unit testing.

          Show
          markflorida@wustl.edu Mark Florida added a comment - This is the kind of thing that could use JS unit testing.
          Hide
          moore.c@wustl.edu Charlie Moore added a comment -

          I've opened some tickets related to this.

          Show
          moore.c@wustl.edu Charlie Moore added a comment - I've opened some tickets related to this.

            People

            • Assignee:
              moore.c@wustl.edu Charlie Moore
              Reporter:
              moore.c@wustl.edu Charlie Moore
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 2 days
                2d
                Remaining:
                Remaining Estimate - 2 days
                2d
                Logged:
                Time Spent - Not Specified
                Not Specified

                  Agile